Fixed Support Points Update in AtBContract #6513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced `setSupportPoints` with `changeSupportPoints` to correctly update the support points.
IllianiBird
added
Bug
StratCon
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6513 +/- ##
=========================================
Coverage 11.28% 11.28%
+ Complexity 6323 6319 -4
=========================================
Files 1080 1080
Lines 137528 137528
Branches 21295 21295
=========================================
+ Hits 15516 15518 +2
+ Misses 120463 120455 -8
- Partials 1549 1555 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setSupportPointswithchangeSupportPointsto correctly update the support points.Fix #6496
Dev Notes
Marking as 'High' due to the importance of SP in StratCon's economics.